Skip to content

Add opt_build option to ci/do_ci.sh.#536

Merged
dubious90 merged 1 commit intoenvoyproxy:masterfrom
oschaaf:do-ci-opt-build
Sep 15, 2020
Merged

Add opt_build option to ci/do_ci.sh.#536
dubious90 merged 1 commit intoenvoyproxy:masterfrom
oschaaf:do-ci-opt-build

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Sep 15, 2020

This is helpful to assist with building Nighthawk's production
ready artifacts via docker build images.

For example:

DOCKER_IMAGE=envoyproxy/envoy-build-[centos|ubuntu] \
  ci/run_envoy_docker.sh ci/do_ci.sh opt_build

Related issue: #525

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

This is helpful to assist with building Nighthawk's production
ready artifacts via docker build images.

For example:

```bash
DOCKER_IMAGE=envoyproxy/envoy-build-[centos|ubuntu] \
  ci/run_envoy_docker.sh ci/do_ci.sh opt_build
```

Related issue: envoyproxy#525

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Sep 15, 2020
@dubious90 dubious90 self-assigned this Sep 15, 2020
Copy link
Copy Markdown
Contributor

@dubious90 dubious90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dubious90 dubious90 merged commit f434a43 into envoyproxy:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants