TerminationPredicateTest: explicitly order std::move/get reference#373
Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom Jun 19, 2020
Merged
TerminationPredicateTest: explicitly order std::move/get reference#373mum4k merged 1 commit intoenvoyproxy:masterfrom
mum4k merged 1 commit intoenvoyproxy:masterfrom
Conversation
Fixes envoyproxy#372 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
qqustc
approved these changes
Jun 19, 2020
Contributor
qqustc
left a comment
There was a problem hiding this comment.
Thank you Otto.
Verified the test now passed with this change.
qqustc
approved these changes
Jun 19, 2020
mum4k
approved these changes
Jun 19, 2020
Collaborator
mum4k
left a comment
There was a problem hiding this comment.
I can't decide if I like the fix or the bug more.
Member
Author
|
Filed #374 as a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com