Merged
Conversation
Fixes envoyproxy#352 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
requested changes
Jun 10, 2020
test/output_formatter_test.cc
Outdated
| } | ||
|
|
||
| TEST_F(MediumOutputCollectorTest, ConsoleOutputFormatter) { | ||
| const auto input_proto = loadProtoFromFile("test/test_data/large-sample.json"); |
Collaborator
There was a problem hiding this comment.
Is there any way we can minimize this testdata file so that it only contains the minimum possible for the test to make sense? It is generally easy to add testdata files by just copying some actual production file, but it tends to hurt on maintenance as other test maintainers don't know which portion of the file is relevant to the intention of the test.
Member
Author
There was a problem hiding this comment.
Yes, good point, that was suboptimal. I pushed 0711c15 to improve, which makes this specific to the problem I'm trying to address here.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Jun 12, 2020
Collaborator
mum4k
left a comment
There was a problem hiding this comment.
Thank you for minimizing the testdata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com