Skip to content

support non-default buildifier/buildozer paths#341

Merged
mum4k merged 4 commits intoenvoyproxy:masterfrom
eric846:ci-buildozer-path-2
Jun 3, 2020
Merged

support non-default buildifier/buildozer paths#341
mum4k merged 4 commits intoenvoyproxy:masterfrom
eric846:ci-buildozer-path-2

Conversation

@eric846
Copy link
Copy Markdown
Contributor

@eric846 eric846 commented Jun 1, 2020

When buildifier or buildozer can't be found, these instructions are printed:

ERROR: Command /usr/local/bin/buildifier not found. If you have buildifier installed, but the binary name is different or it's not available in $GOPATH/bin, please use BUILDIFIER_BIN environment variable to specify the path. Example:
    export BUILDIFIER_BIN=`which buildifier`
If you don't have buildifier installed, you can install it by:
    go get -u github.com/bazelbuild/buildtools/buildifier
ERROR: Command /usr/local/bin/buildozer not found. If you have buildozer installed, but the binary name is different or it's not available in $GOPATH/bin, please use BUILDOZER_BIN environment variable to specify the path. Example:
    export BUILDOZER_BIN=`which buildozer`
If you don't have buildozer installed, you can install it by:
    go get -u github.com/bazelbuild/buildtools/buildozer

After doing the go get and export, we still get the same message.

It turns out do_ci.sh unconditionally overwrites BUILDIFIER_BIN and BUILDOZER_BIN.

We have been using this workaround:

ln -s $HOME/go/bin/buildifier /usr/local/bin/buildifier 
ln -s $HOME/go/bin/buildozer /usr/local/bin/buildozer

eric846 added 2 commits June 1, 2020 17:23
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
oschaaf
oschaaf previously approved these changes Jun 1, 2020
Copy link
Copy Markdown
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric846 eric846 added the waiting-for-review A PR waiting for a review. label Jun 1, 2020
mum4k
mum4k previously approved these changes Jun 2, 2020
@mum4k
Copy link
Copy Markdown
Collaborator

mum4k commented Jun 2, 2020

@eric846, can you try to restart the automated checks to get a passing run? We usually do it by pushing another commit or two.

@mum4k mum4k added waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. and removed waiting-for-review A PR waiting for a review. labels Jun 2, 2020
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 dismissed stale reviews from mum4k and oschaaf via c979fc6 June 2, 2020 23:05
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
@eric846 eric846 added waiting-for-review A PR waiting for a review. and removed waiting-for-changes A PR waiting for comments to be resolved and changes to be applied. labels Jun 3, 2020
@eric846
Copy link
Copy Markdown
Contributor Author

eric846 commented Jun 3, 2020

@mum4k finally passed

@mum4k mum4k merged commit 2f0f0e6 into envoyproxy:master Jun 3, 2020
@eric846 eric846 removed the waiting-for-review A PR waiting for a review. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants