Log exception in ProcessImpl::run()#327
Conversation
Related to envoyproxy#317 Log any exceptions and rethrow. This is to assist with diagnosis once it happens again in the CI env. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
| cluster_manager_ = cluster_manager_factory_->clusterManagerFromProto(bootstrap); | ||
| maybeCreateTracingDriver(bootstrap.tracing()); | ||
| cluster_manager_->setInitializedCb([this]() -> void { init_manager_.initialize(init_watcher_); }); | ||
| try { |
There was a problem hiding this comment.
This was already a fairly long function to begin with. How hard would it be to refactor the content of the new try { } into a separate private method? That way we could separate the exception handling (the outer run method) from the business logic (the new private method) and make this a bit easier to follow.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
|
Coverage is flaking because of a single line sometimes not getting hit: |
|
Is the flaky coverage something we should address / track? Also can you help me by triggering it again so this becomes able to merge? |
I'm trying to address this in-place, it should be possible to reliably hit the line I mentioned. |
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Related to #317
Log any exceptions and rethrow. This is to assist with
diagnosis once it happens again in the CI env.
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com