Nighthawk docker image fixes and hard shutdown timeout configuration from cli#1407
Merged
eric846 merged 2 commits intoenvoyproxy:mainfrom Sep 15, 2025
Merged
Conversation
This commit configures the hard shutdown timeout for nighthawk_client from command line option with configured connection connect timeout period. This also preserves the default timeout of 30s unless explicitly configured by the client. Original change for context: 0f8478e Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com>
1409043 to
16e93eb
Compare
eric846
requested changes
Sep 8, 2025
Contributor
eric846
left a comment
There was a problem hiding this comment.
We might consider splitting off the Docker and drain timeout parts. We would be close to being able to merge the Docker parts.
Additional minor fixes and improvements: * Add a new ci command to just build nighthawk docker image. * Fix Dockerfile context for nighthawk image build. * Fix default config for nighthawk_test_server. * Expose correct server ports for nighthawk docker image. * Fix/Add default entrypoint as `nighthawk_test_server` for docker image. * Install curl as part of nighthawk docker image build(useful for developement and debugging) Signed-off-by: Deepesh Pathak <deepeshpathak09@gmail.com> Signed-off-by: Deepesh Pathak <deepesh.pathak@isovalent.com>
16e93eb to
426b5a9
Compare
fristonio
commented
Sep 15, 2025
Contributor
Author
fristonio
left a comment
There was a problem hiding this comment.
Sorry for the delayed response.
eric846
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message for more details.