Skip to content

Server extensions: enhance naming of bool maybeSendErrorReply() #558

@oschaaf

Description

@oschaaf

currently we have:

bool maybeSendErrorReply()

This method returns true iff configuration state was invalid (and therefore an error reply was sent).
A refactor like

bool validateOrSendError()

should yield easier to grok code, but isn't a strict rename as we need to invert the return value.

This came up in a review discussion [1], filing this issue to track status. It should be an easy and mechanical
refactor.

[1] Context: https://github.com/envoyproxy/nighthawk/pull/512/files/79b25083d665124d713f53c6794f9a76dba9df21#diff-4a3530f1a306ea777ea7bedb8a658361

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions