-
Notifications
You must be signed in to change notification settings - Fork 89
Coverage started flaking #296
Copy link
Copy link
Closed
Labels
P0Highest priorityHighest priority
Description
As of merging #295 coverage started flaking.
These lines from the test server filter are no longer always covered:
65 | 0 | decoder_callbacks_->sendLocalReply(
66 | 0 | static_cast<Envoy::Http::Code>(500),
67 | 0 | fmt::format("test-server didn't understand the request: {}", *error_message_), nullptr,
68 | 0 | absl::nullopt, "");
69 | 0 | }
Apparently, the default simple warmup we had helped structurally hitting these lines.
It would be good to have an explicit test for this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P0Highest priorityHighest priority