chore: use testify instead of t.Fatal or t.Error#1040
Merged
mmorel-35 merged 1 commit intoenvoyproxy:mainfrom Jan 28, 2025
Merged
chore: use testify instead of t.Fatal or t.Error#1040mmorel-35 merged 1 commit intoenvoyproxy:mainfrom
mmorel-35 merged 1 commit intoenvoyproxy:mainfrom
Conversation
456808d to
c527e51
Compare
valerian-roche
previously approved these changes
Dec 2, 2024
pkg/cache/v3/delta_test.go
Outdated
| if !cmp.Equal(want, got, protocmp.Transform()) { | ||
| t.Errorf("got resources %v, want %v", got, want) | ||
| } | ||
| assert.Truef(t, cmp.Equal(want, got, protocmp.Transform()), "got resources %v, want %v", got, want) |
Contributor
There was a problem hiding this comment.
Nit, using cmp.Diff in the error message makes it much simpler to process errors imo
pkg/cache/v3/delta_test.go
Outdated
| if reflect.DeepEqual(streams[testTypes[0]].GetResourceVersions(), nextVersionMap) { | ||
| t.Fatalf("versionMap for the endpoint resource type did not change, received: %v, instead of an empty map", nextVersionMap) | ||
| } | ||
| require.Falsef(t, reflect.DeepEqual(streams[testTypes[0]].GetResourceVersions(), nextVersionMap), "versionMap for the endpoint resource type did not change, received: %v, instead of an empty map", nextVersionMap) |
Contributor
There was a problem hiding this comment.
Same remark: using cmp.Equal/cmp.Diff could be nicer in error messages
Contributor
Author
|
Thank you @valerian-roche |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3fca00f to
04d5899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses testify instead of testing for t.Fatal or t.Error calls