Skip to content

HTTP PATCH method seems to be unsupported by the library #176

@glebmish

Description

@glebmish

Hi!

I use PATCH requests that go through envoy and logs are written with als implemented on golang. I expect to see "PATCH" as a result of this code:

import (
	envoy "github.com/envoyproxy/go-control-plane/envoy/data/accesslog/v2"
)

func RequestMethod(ent *envoy.HTTPAccessLogEntry) string {
	return ent.GetRequest().GetRequestMethod().String()
}

Instead, I see "METHOD_UNSPECIFIED". When I tried to find the reason in the library code, I found that PATCH is not in the list of request methods (https://github.com/envoyproxy/go-control-plane/blob/master/envoy/api/v2/core/base.pb.go#L67)

What do you think about this? Was it omitted intentionally or just missed? Can it be the reason of the problem I described?

Thank you for your help.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions