bugfix: remove stale listener condition#929
Merged
arkodg merged 4 commits intoenvoyproxy:mainfrom Jan 18, 2023
Merged
Conversation
Signed-off-by: Hamzah Qudsi <hqudsi@datawire.io>
Codecov Report
@@ Coverage Diff @@
## main #929 +/- ##
==========================================
+ Coverage 63.41% 63.72% +0.30%
==========================================
Files 53 54 +1
Lines 7487 7589 +102
==========================================
+ Hits 4748 4836 +88
- Misses 2441 2451 +10
- Partials 298 302 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
arkodg
reviewed
Jan 17, 2023
added 2 commits
January 17, 2023 16:19
Signed-off-by: Hamzah Qudsi <hqudsi@datawire.io>
Signed-off-by: Hamzah Qudsi <hqudsi@datawire.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the listener status in the Gateway resource could be left stale if one of the listeners is removed.
We add new method to GatewayContext to reset the listener status and listener contexts and is called before re-computing
Testing:
Fixes #773