Codecov Report

Merging #908 (baffca3) into main (29a8640) will decrease coverage by 0.14%.
The diff coverage is 48.80%.

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   63.40%   63.26%   -0.15%     
==========================================
  Files          53       53              
  Lines        7487     7556      +69     
==========================================
+ Hits         4747     4780      +33     
- Misses       2440     2468      +28     
- Partials      300      308       +8     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg CI is failing b/c the controller-runtime cache is unable to sync. The cache is unable to sync b/c the RateLimitFilter CRD is not installed by the kube-deploy target. You need the following:

$ git diff
diff --git a/internal/provider/kubernetes/config/crd/kustomization.yaml b/internal/provider/kubernetes/config/crd/kustomization.yaml
index 1d85bb9d..c5e344f4 100644
--- a/internal/provider/kubernetes/config/crd/kustomization.yaml
+++ b/internal/provider/kubernetes/config/crd/kustomization.yaml
@@ -4,6 +4,7 @@
 resources:
 - bases/config.gateway.envoyproxy.io_envoyproxies.yaml
 - bases/gateway.envoyproxy.io_authenticationfilters.yaml
+- bases/gateway.envoyproxy.io_ratelimitfilters.yaml
 #+kubebuilder:scaffold:crdkustomizeresource

Creating an HTTPRoute that references a RateLimitFilter results in:

$ kubectl get httproute/backend -o yaml
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: backend
  namespace: default
...
status:
  parents:
  - conditions:
    - lastTransitionTime: "2023-01-17T21:37:43Z"
      message: 'Reference not found for filter type: ExtensionRef'
      observedGeneration: 1
      reason: BackendNotFound
      status: "False"
      type: ResolvedRefs
    controllerName: gateway.envoyproxy.io/gatewayclass-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: eg

You need to update filters.go in the gatewayapi translator to process the RateLimitFilter. This step can be done in a separate PR.

@arkodg CI is failing b/c the controller-runtime cache is unable to sync. The cache is unable to sync b/c the RateLimitFilter CRD is not installed by the kube-deploy target. You need the following:

$ git diff
diff --git a/internal/provider/kubernetes/config/crd/kustomization.yaml b/internal/provider/kubernetes/config/crd/kustomization.yaml
index 1d85bb9d..c5e344f4 100644
--- a/internal/provider/kubernetes/config/crd/kustomization.yaml
+++ b/internal/provider/kubernetes/config/crd/kustomization.yaml
@@ -4,6 +4,7 @@
 resources:
 - bases/config.gateway.envoyproxy.io_envoyproxies.yaml
 - bases/gateway.envoyproxy.io_authenticationfilters.yaml
+- bases/gateway.envoyproxy.io_ratelimitfilters.yaml
 #+kubebuilder:scaffold:crdkustomizeresource

Creating an HTTPRoute that references a RateLimitFilter results in:

$ kubectl get httproute/backend -o yaml
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: backend
  namespace: default
...
status:
  parents:
  - conditions:
    - lastTransitionTime: "2023-01-17T21:37:43Z"
      message: 'Reference not found for filter type: ExtensionRef'
      observedGeneration: 1
      reason: BackendNotFound
      status: "False"
      type: ResolvedRefs
    controllerName: gateway.envoyproxy.io/gatewayclass-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: eg

You need to update filters.go in the gatewayapi translator to process the RateLimitFilter. This step can be done in a separate PR.

thanks for helping debug this issue ! will make the change in the PR