implement parent ref port matching when specified#885
Merged
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom Jan 11, 2023
Merged
implement parent ref port matching when specified#885Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
Conversation
When port is specified in a parentRef, only select listeners if they have a matching port, and set conditions appropriately if not. Closes envoyproxy#784. Signed-off-by: Steve Kriss <krisss@vmware.com>
Contributor
Author
|
Conformance test now running & passing: https://github.com/envoyproxy/gateway/actions/runs/3888096972/jobs/6635148298#step:6:12686 |
arkodg
reviewed
Jan 10, 2023
Xunzhuo
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When port is specified in a parentRef, only select listeners if they have a matching port, and set
conditions appropriately if not.
Closes #784.
Signed-off-by: Steve Kriss krisss@vmware.com