Skip to content

Bump to gateway api v0.6.0#874

Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg:gapi-bump-v0.6.0
Jan 10, 2023
Merged

Bump to gateway api v0.6.0#874
arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg:gapi-bump-v0.6.0

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Jan 9, 2023 •
edited
Loading

  • update go module
  • copy over newer experimental CRDs into testdata
  • incorporate ObservedGeneration into status condition comparisons
  • ensure that the two gateway status update code paths (one when a service or deployment linked to a gateway changes and the second where the gateway-api translator has recomputed the status) use the same status updater function, ensuring that the ObservedGeneration is always up to date in all status fields

Fixes: #716 Fixes: #839

Signed-off-by: Arko Dasgupta arko@tetrate.io

Bump to gateway api v0.6.0
767c0b5 
* update go module
* copy over newer experimental CRDs into testdata
* incorporate ObservedGeneration into status condition comparisons

Fixes: envoyproxy#716
Fixes: envoyproxy#839

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner January 9, 2023 18:39
@arkodg arkodg marked this pull request as draft January 9, 2023 18:39
Arko Dasgupta added 2 commits January 9, 2023 11:36
rm double cond merge && update status if svc empty
364255e 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
combine gateway status code path
08eb586 
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #874 (08eb586) into main (b05aa93) will increase coverage by 0.22%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   63.91%   64.13%   +0.22%     
==========================================
  Files          51       52       +1     
  Lines        6869     7129     +260     
==========================================
+ Hits         4390     4572     +182     
- Misses       2203     2275      +72     
- Partials      276      282       +6
Impacted Files Coverage Δ
internal/status/gateway.go 0.00% <0.00%> (ø)
internal/status/status.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/controller.go 47.28% <40.00%> (+0.74%) ⬆️
internal/gatewayapi/contexts.go 77.47% <50.00%> (+0.12%) ⬆️
internal/provider/kubernetes/predicates.go 61.93% <100.00%> (+2.14%) ⬆️
internal/status/conditions.go 96.15% <100.00%> (+0.15%) ⬆️
internal/ir/zz_generated.deepcopy.go 14.84% <0.00%> (-2.47%) ⬇️
internal/ir/xds.go 78.06% <0.00%> (-1.48%) ⬇️
internal/xds/translator/route.go 84.78% <0.00%> (-1.13%) ⬇️
internal/xds/translator/listener.go 81.16% <0.00%> (-0.74%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg arkodg marked this pull request as ready for review January 9, 2023 21:31
@arkodg arkodg mentioned this pull request Jan 9, 2023
Closed
@arkodg arkodg requested review from Xunzhuo and skriss January 9, 2023 21:56
Xunzhuo
Xunzhuo approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arkodg arkodg merged commit 35c4f63 into envoyproxy:main Jan 10, 2023
@arkodg arkodg deleted the gapi-bump-v0.6.0 branch January 10, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@skriss skriss Awaiting requested review from skriss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump Kube Provider Test Data Manifests to v0.6.0 Update to the v0.6.0 Gateway API release

3 participants

@arkodg @codecov-commenter @Xunzhuo