Skip to content

Bump sigs.k8s.io/gateway-api from 0.6.0-rc2 to 0.6.0#828

Closed
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/sigs.k8s.io/gateway-api-0.6.0
Closed

Bump sigs.k8s.io/gateway-api from 0.6.0-rc2 to 0.6.0#828
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/go_modules/sigs.k8s.io/gateway-api-0.6.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Dec 21, 2022 •
edited
Loading

Bumps sigs.k8s.io/gateway-api from 0.6.0-rc2 to 0.6.0.

Release notes

Sourced from sigs.k8s.io/gateway-api's releases.

v0.6.0

API versions: v1beta1, v1alpha2

Major Changes

ReferenceGrant moves to v1beta1, ReferencePolicy removed

With more implementations now supporting ReferenceGrant (and more conformance coverage of the resource), we've moved ReferenceGrant to v1beta1 in this release. Note that moving to beta also moves the object to the Standard channel (it was Experimental previously).

We've also removed the already-deprecated ReferencePolicy resource, so please move over to the shiny new ReferenceGrant, which has all the same features.

  • Promotes ReferenceGrant to the v1beta1 API and the standard release channel (#1455, @​nathancoleman)
  • ReferencePolicy has been removed from the API in favor of ReferenceGrant. (#1406, @​robscott)

Introduce GRPCRoute

The GRPCRoute resource has been introduced in order to simplify the routing of GRPC requests. Its design is described in GEP-1016. As it is a new resource, it is introduced in the experimental channel.

Thanks to @​gnossen for pushing this ahead.

Status updates

As described in GEP-1364, status conditions have been updated within the Gateway resource to make it more consistent with the rest of the API. These changes, along with some other status changes, are detailed below.

Gateway:

  • New Accepted and Programmed conditions introduced.
  • Scheduled condition deprecated.
  • Core Conditions now Accepted and Programmed.
  • Moves to Extended: Ready.

Gateway Listener:

  • New Accepted and Programmed conditions introduced.
  • Detached condition deprecated.
  • Core Conditions now Accepted, Programmed, ResolvedRefs, and Conflicted.
  • Moves to Extended: Ready.

All Resources:

  • The Accepted Condition now has a Pending reason, which is the default until the condition is updated by a controller.

Route resources:

... (truncated)

Changelog

Sourced from sigs.k8s.io/gateway-api's changelog.

v0.6.0

Major Changes

ReferenceGrant moves to v1beta1, ReferencePolicy removed

With more implementations now supporting ReferenceGrant (and more conformance coverage of the resource), we've moved ReferenceGrant to v1beta1 in this release. Note that moving to beta also moves the object to the Standard channel (it was Experimental previously).

We've also removed the already-deprecated ReferencePolicy resource, so please move over to the shiny new ReferenceGrant, which has all the same features.

  • Promotes ReferenceGrant to the v1beta1 API and the standard release channel (#1455, @​nathancoleman)
  • ReferencePolicy has been removed from the API in favor of ReferenceGrant. (#1406, @​robscott)

Introduce GRPCRoute

The GRPCRoute resource has been introduced in order to simplify the routing of GRPC requests. Its design is described in GEP-1016. As it is a new resource, it is introduced in the experimental channel.

Thanks to @​gnossen for pushing this ahead.

Status updates

As described in GEP-1364, status conditions have been updated within the Gateway resource to make it more consistent with the rest of the API. These changes, along with some other status changes, are detailed below.

Gateway:

  • New Accepted and Programmed conditions introduced.
  • Scheduled condition deprecated.
  • Core Conditions now Accepted and Programmed.
  • Moves to Extended: Ready.

Gateway Listener:

  • New Accepted and Programmed conditions introduced.
  • Detached condition deprecated.
  • Core Conditions now Accepted, Programmed, ResolvedRefs, and Conflicted.
  • Moves to Extended: Ready.

All Resources:

  • The Accepted Condition now has a Pending reason, which is the default until the condition is updated by a controller.

Route resources:

... (truncated)

Commits
  • 6c222d3 chore: update default version to v0.6.0
  • ca470e2 Merge pull request #1614 from shaneutt/shaneutt/v0.6.0-changelog
  • 9522bd0 docs: add v0.6.0 changelog entry
  • 6a8738a Merge pull request #1594 from youngnick/973-fix
  • 05fa505 Update wording on ParentRef field to require AllowedRoutes or ReferenceGrant
  • dc314b1 Assert observedGeneration is incremented in Status.Conditions. (#1586)
  • 9c9429a Merge pull request #1609 from frankbu/impl/istio
  • 3c693e0 fix link target
  • 35c6988 Update istio implementation info
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner December 21, 2022 14:18
@dependabot dependabot bot added kind/dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 21, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #828 (970ccf4) into main (ec4418f) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   64.30%   64.12%   -0.18%     
==========================================
  Files          46       46              
  Lines        6189     6189              
==========================================
- Hits         3980     3969      -11     
- Misses       1974     1983       +9     
- Partials      235      237       +2
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 52.02% <0.00%> (-1.76%) ⬇️
internal/provider/kubernetes/helpers.go 76.22% <0.00%> (-0.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Dec 21, 2022

@Xunzhuo, looks like the bots are taking over your assigned work items 😄

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Dec 21, 2022

looks like these 2 tests are consistently failing ONLY for k8s v1.23.6

--- FAIL: TestGatewayAPIConformance/GatewaySecretMissingReferenceGrant (60.04s)
[12370](https://github.com/envoyproxy/gateway/actions/runs/3751177865/jobs/6371842423#step:6:12371)
        --- FAIL: TestGatewayAPIConformance/GatewaySecretMissingReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (60.01s)
[12371](https://github.com/envoyproxy/gateway/actions/runs/3751177865/jobs/6371842423#step:6:12372)
    --- FAIL: TestGatewayAPIConformance/GatewaySecretInvalidReferenceGrant (60.12s)
[12372](https://github.com/envoyproxy/gateway/actions/runs/3751177865/jobs/6371842423#step:6:12373)
        --- FAIL: TestGatewayAPIConformance/GatewaySecretInvalidReferenceGrant/Gateway_listener_should_have_a_false_ResolvedRefs_condition_with_reason_RefNotPermitted (60.01s)

@dependabot
Bump sigs.k8s.io/gateway-api from 0.6.0-rc2 to 0.6.0
d97ff50 
Bumps [sigs.k8s.io/gateway-api](https://github.com/kubernetes-sigs/gateway-api) from 0.6.0-rc2 to 0.6.0.
- [Release notes](https://github.com/kubernetes-sigs/gateway-api/releases)
- [Changelog](https://github.com/kubernetes-sigs/gateway-api/blob/main/CHANGELOG.md)
- [Commits](kubernetes-sigs/gateway-api@v0.6.0-rc2...v0.6.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/gateway-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/gateway-api-0.6.0 branch from 970ccf4 to d97ff50 Compare December 21, 2022 18:58
@arkodg arkodg mentioned this pull request Dec 23, 2022
Closed
@danehans
Copy link
Copy Markdown
Contributor

danehans commented Dec 29, 2022

Regarding #828 (comment), what do others think about dropping support for k8s v1.23.6?

cc: @Xunzhuo @arkodg @AliceProxy @skriss @zirain @youngnick

@danehans danehans mentioned this pull request Dec 30, 2022
Closed
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 3, 2023

Regarding #828 (comment), what do others think about dropping support for k8s v1.23.6?

cc: @Xunzhuo @arkodg @AliceProxy @skriss @zirain @youngnick

we shouldnt drop support, but prioritize triaging this issue instead

@skriss
Copy link
Copy Markdown
Contributor

skriss commented Jan 3, 2023 •
edited
Loading

Looks like this may be related to some recent conformance changes to ensure observedGeneration is being properly set in conditions:

The same logs are shown in the latest 1.25.x run: https://github.com/envoyproxy/gateway/actions/runs/3752047527/jobs/6479209006#step:6:11785

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Jan 4, 2023

Yes, this is not related to the kube version, looks like some changes of gwapi.

@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Jan 4, 2023

Let me send a manual update for v0.6.0.

@Xunzhuo Xunzhuo mentioned this pull request Jan 4, 2023
Closed
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jan 4, 2023

closing in favor of #853

@arkodg arkodg closed this Jan 4, 2023
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/sigs.k8s.io/gateway-api-0.6.0 branch January 4, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@skriss skriss

Labels

go Pull requests that update Go code kind/dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@codecov-commenter @arkodg @danehans @skriss @Xunzhuo