Adds AuthenticationFilter Support to Resource Translator#804
Merged
danehans merged 1 commit intoenvoyproxy:mainfrom Jan 10, 2023
Merged
Adds AuthenticationFilter Support to Resource Translator#804danehans merged 1 commit intoenvoyproxy:mainfrom
danehans merged 1 commit intoenvoyproxy:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 63.91% 64.32% +0.41%
==========================================
Files 50 50
Lines 6506 6532 +26
==========================================
+ Hits 4158 4202 +44
+ Misses 2087 2073 -14
+ Partials 261 257 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
096bcc7 to
5e12928
Compare
5e12928 to
d601dea
Compare
skriss
reviewed
Dec 21, 2022
internal/gatewayapi/translator.go
Outdated
Contributor
There was a problem hiding this comment.
It's not 100% clear in the Gateway API spec, but I think if the filter ref can't be resolved (i.e. the referent doesn't exist), then setting a ResolvedRefs: false condition would be more appropriate than Accepted: false (UnsupportedValue).
Contributor
There was a problem hiding this comment.
(For unknown filter types, what we're doing here still makes sense though)
Contributor
Author
d601dea to
07ec1b4
Compare
Signed-off-by: danehans <daneyonhansen@gmail.com>
07ec1b4 to
fbc7945
Compare
arkodg
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AuthenticationFilter support to the resource translator.
xref:#790