fix: propagate the HTTPFilter translation errors to the outer layer#7556
Merged
zhaohuabing merged 6 commits intoenvoyproxy:mainfrom Nov 26, 2025
Merged
fix: propagate the HTTPFilter translation errors to the outer layer#7556zhaohuabing merged 6 commits intoenvoyproxy:mainfrom
zhaohuabing merged 6 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7556 +/- ##
==========================================
- Coverage 72.33% 72.26% -0.08%
==========================================
Files 232 232
Lines 34114 34103 -11
==========================================
- Hits 24676 24644 -32
- Misses 7668 7682 +14
- Partials 1770 1777 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dc7f5b0 to
0dcab0a
Compare
zhaohuabing
commented
Nov 19, 2025
internal/gatewayapi/testdata/extensions/httproute-with-custom-backend-invalid-group.out.yaml
Outdated
Show resolved
Hide resolved
Member
Author
|
I just found another issue while working on this PR: currently, the ir routes are not generated for HTTPRoute Rules with invalid HTTPFilters. If any rules have invalid filters, the user requests will get 404 not found. We should generate a 500 directResponse for these rules, like what we did with failed backendRefs. Let's handle this in a separate PR. |
0dcab0a to
ca5e6f3
Compare
ca5e6f3 to
008b334
Compare
arkodg
reviewed
Nov 20, 2025
33b4b12 to
8001531
Compare
zhaohuabing
commented
Nov 20, 2025
| status: "False" | ||
| message: Route is accepted | ||
| reason: Accepted | ||
| status: "True" |
Member
Author
There was a problem hiding this comment.
Accepted should be True for unresolved filters.
lboynton
reviewed
Nov 20, 2025
internal/gatewayapi/testdata/httproute-with-header-filter-no-valid-headers.out.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
de9a6cc to
c29c132
Compare
kkk777-7
reviewed
Nov 24, 2025
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
kkk777-7
approved these changes
Nov 24, 2025
Member
|
LGTM, thanks! |
arkodg
reviewed
Nov 25, 2025
| type: Accepted | ||
| - lastTransitionTime: null | ||
| message: 'Unable to translate HTTPRouteFilter: default/direct-response-value-ref-not-found' | ||
| message: 'Unable to translate HTTPRouteFilter: default/direct-response-value-ref-not-found.' |
Contributor
There was a problem hiding this comment.
not related to this PR, but we should consider updating reason from BackendNotFound to something better for this case in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propagates the HTTPFilter translation errors to the out layer, so they can be handled with other route translation errors together in the
processHTTPRouteParentRefsmethod.This PR doesn't fix #7545, but it will allow us to associate an HTTPFilter translation error with a specific HTTPRule. This is a prerequisite for resolving #7545, where we need to set the
Acceptedstatus as true for mixed valid and invalid rules and generate the xDS for valid rules.