Skip to content

[release/v1.4] cherry-pick: do not return 500 for all requests when part of BackendRefs are invalid#7504

Merged
zhaohuabing merged 1 commit intoenvoyproxy:release/v1.4from
zhaohuabing:v1.4-cherry-pick-7488
Nov 14, 2025
Merged

[release/v1.4] cherry-pick: do not return 500 for all requests when part of BackendRefs are invalid#7504
zhaohuabing merged 1 commit intoenvoyproxy:release/v1.4from
zhaohuabing:v1.4-cherry-pick-7488

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

cherry pick #7488 as it would be difficult for the release manager to cherry pick this one - the route.go changed a lot.

do not return 500 for all requests when part of BackendRefs are invalid

@zhaohuabing zhaohuabing requested a review from a team as a code owner November 13, 2025 11:56
@zhaohuabing zhaohuabing marked this pull request as draft November 13, 2025 11:56
@zhaohuabing zhaohuabing force-pushed the v1.4-cherry-pick-7488 branch from e535f44 to 89d9a93 Compare November 13, 2025 11:59
@zhaohuabing zhaohuabing marked this pull request as ready for review November 13, 2025 12:04
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.29%. Comparing base (36ad33d) to head (a7efe26).
⚠️ Report is 1 commits behind head on release/v1.4.

Files with missing lines Patch % Lines
internal/gatewayapi/route.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.4    #7504      +/-   ##
================================================
+ Coverage         71.27%   71.29%   +0.02%     
================================================
  Files               217      217              
  Lines             29436    29439       +3     
================================================
+ Hits              20980    20989       +9     
+ Misses             6919     6915       -4     
+ Partials           1537     1535       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…invalid (envoyproxy#7488)

* do not return 500 for all requests when part of BackendRefs are invalid

Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the v1.4-cherry-pick-7488 branch from 89d9a93 to a7efe26 Compare November 13, 2025 12:08
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team November 14, 2025 01:27
@zhaohuabing zhaohuabing merged commit b165f95 into envoyproxy:release/v1.4 Nov 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants