feat(securitypolicy): Update API to support tcp security policy#7168
Merged
arkodg merged 10 commits intoenvoyproxy:mainfrom Oct 10, 2025
Merged
feat(securitypolicy): Update API to support tcp security policy#7168arkodg merged 10 commits intoenvoyproxy:mainfrom
arkodg merged 10 commits intoenvoyproxy:mainfrom
Conversation
…king down larger pr's in to smaller ones Signed-off-by: davem-git <demathieu@gmail.com>
arkodg
previously approved these changes
Oct 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7168 +/- ##
==========================================
+ Coverage 71.07% 71.14% +0.07%
==========================================
Files 228 228
Lines 40678 40678
==========================================
+ Hits 28910 28940 +30
+ Misses 10072 10048 -24
+ Partials 1696 1690 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…curity-policy-api
…s clientIP and what defines a clientIP Signed-off-by: davem-git <demathieu@gmail.com>
…ateway into feat-tcp-security-policy-api
Contributor
Author
|
add comments as requested by @zhaohuabing #6496 (comment) |
Signed-off-by: davem-git <demathieu@gmail.com>
…ateway into feat-tcp-security-policy-api
Signed-off-by: davem-git <demathieu@gmail.com>
Member
|
@davem-git LGTM. Please rum |
zhaohuabing
previously approved these changes
Oct 10, 2025
Contributor
Author
|
thanks trying that now. I have this issue that i'm trying to resolve. seeing if its required to fix this though go generate ./...
===========> Running kube-generate-examples ...
~/LocalDocuments/gitrepo/gateway_forked/examples/extension-server ~/LocalDocuments/gitrepo/gateway_forked
../../../../../go/pkg/mod/golang.org/x/tools@v0.36.0/internal/gocommand/vendor.go:17:2: missing go.sum entry for module providing package golang.org/x/mod/semver (imported by golang.org/x/tools/internal/gocommand); to add:
go get golang.org/x/tools/internal/gocommand@v0.36.0
../../../../../go/pkg/mod/golang.org/x/tools@v0.36.0/internal/imports/mod.go:21:2: missing go.sum entry for module providing package golang.org/x/mod/module (imported by golang.org/x/tools/internal/imports); to add:
go get golang.org/x/tools/internal/imports@v0.36.0
../../../../../go/pkg/mod/k8s.io/kube-openapi@v0.0.0-20250814151709-d7b6acb124c3/pkg/validation/spec/gnostic.go:23:2: missing go.sum entry for module providing package github.com/go-openapi/jsonreference (imported by k8s.io/kube-openapi/pkg/validation/spec); to add:
go get k8s.io/kube-openapi/pkg/validation/spec@v0.0.0-20250814151709-d7b6acb124c3
make[2]: *** [generate] Error 1
~/LocalDocuments/gitrepo/gateway_forked |
Signed-off-by: davem-git <demathieu@gmail.com>
Contributor
Author
|
It seems like it did @zhaohuabing @arkodg the gen-check have been run, when i run it again locally it looks good. Matching the CI error with the commit also looks good |
zhaohuabing
approved these changes
Oct 10, 2025
This was referenced Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
This PR adds support for TCP security policys in the API layer
Which issue(s) this PR fixes:
Fixes ##4908
Release Notes: Yes/No
NO