Skip to content

use use length check instead of a reflect in EEP status#7061

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg:use-len-eep-status
Sep 25, 2025
Merged

use use length check instead of a reflect in EEP status#7061
arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg:use-len-eep-status

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Sep 25, 2025

Similar to #7012

@arkodg arkodg requested a review from a team as a code owner September 25, 2025 07:02
@arkodg arkodg changed the title use use length check instead of a relfect in EEP status use use length check instead of a reflect in EEP status Sep 25, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.07%. Comparing base (a131a8a) to head (a86001b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/runner/runner.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7061      +/-   ##
==========================================
+ Coverage   71.04%   71.07%   +0.03%     
==========================================
  Files         227      227              
  Lines       40435    40435              
==========================================
+ Hits        28726    28740      +14     
+ Misses      10012    10000      -12     
+ Partials     1697     1695       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Similar to envoyproxy#7012

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@zirain
Copy link
Copy Markdown
Member

zirain commented Sep 25, 2025

/retest

@arkodg arkodg merged commit 58eab94 into envoyproxy:main Sep 25, 2025
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants