translator: move EnvoyProxy validation out of Provider#7009
Merged
zirain merged 5 commits intoenvoyproxy:mainfrom Oct 31, 2025
Merged
translator: move EnvoyProxy validation out of Provider#7009zirain merged 5 commits intoenvoyproxy:mainfrom
zirain merged 5 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7009 +/- ##
==========================================
+ Coverage 72.28% 72.32% +0.04%
==========================================
Files 231 231
Lines 33952 33999 +47
==========================================
+ Hits 24542 24590 +48
- Misses 7639 7642 +3
+ Partials 1771 1767 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rudrakhp
previously approved these changes
Sep 20, 2025
cnvergence
previously approved these changes
Sep 24, 2025
arkodg
reviewed
Sep 24, 2025
arkodg
reviewed
Sep 25, 2025
arkodg
reviewed
Sep 25, 2025
b8620be to
757a969
Compare
zirain
commented
Sep 26, 2025
5c6f847 to
b046000
Compare
arkodg
reviewed
Oct 18, 2025
arkodg
reviewed
Oct 18, 2025
arkodg
reviewed
Oct 18, 2025
arkodg
reviewed
Oct 18, 2025
| gCtx.ResetListeners(resources, envoyproxyMap) | ||
| if ep := gCtx.envoyProxy; ep != nil { | ||
| key := utils.NamespacedName(ep) | ||
| if err, exits := envoyproxyValidationErrorMap[key]; exits { |
Contributor
There was a problem hiding this comment.
on L389
// Gateways that are not accepted by the controller because they reference an invalid EnvoyProxy.
if status.GatewayNotAccepted(gCtx.Gateway) {
but we are agin setting the status for the same reason, is this correct ?
Member
Author
There was a problem hiding this comment.
let's try to recall what's happen on Monday.
Member
Author
There was a problem hiding this comment.
it's different.
For L390, it's generally means EnvoyProxy not found.
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
reviewed
Oct 31, 2025
arkodg
approved these changes
Oct 31, 2025
zhaohuabing
approved these changes
Oct 31, 2025
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
xref: #6752