fix: race condition in watchable subscribe#6566
fix: race condition in watchable subscribe#6566rudrakhp merged 1 commit intoenvoyproxy:mainfrom rudrakhp:fix_subscribe_race
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6566 +/- ##
==========================================
+ Coverage 70.77% 70.79% +0.02%
==========================================
Files 224 224
Lines 38614 38646 +32
==========================================
+ Hits 27328 27359 +31
- Misses 9695 9698 +3
+ Partials 1591 1589 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
should we move this above r.watchResources ? so we can force ordering and make sure status are ready for subscriptions ?
There was a problem hiding this comment.
Don't see watchResources being called in offline controller, maybe move it to it's dedicated subscribeToResources?
There was a problem hiding this comment.
Moved it to subscribeToResources.
|
thanks @rudrakhp for reworking this into a simpler PR, appreciate it, added a minor comment |
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
|
/retest |
What type of PR is this?
fix: race condition in watchable subscribe calls from main routine
What this PR does / why we need it:
To fix race conditions in Subscribe calls
Which issue(s) this PR fixes:
Fixes #5505
Related #6412
Release Notes: Yes