Codecov Report

Merging #654 (4ba0d5e) into main (6f540b5) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   62.69%   62.96%   +0.26%     
==========================================
  Files          47       47              
  Lines        5756     5756              
==========================================
+ Hits         3609     3624      +15     
+ Misses       1916     1899      -17     
- Partials      231      233       +2     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thanks for bumping this, any specific reason apart from running envoy with the latest image features and fixes ?
took a peek into the release notes https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.24/v1.24.0 and the only thing that stood out was total_weight being deprecated (all we'll need to do is delete the line)

thanks for bumping this, any specific reason apart from running envoy with the latest image features and fixes ?

Just that; I figure as an Envoy-aligned project we'll want to keep pretty up-to-date with the latest and greatest. It also helps us stay on top of deprecations/etc.

the only thing that stood out was total_weight being deprecated (all we'll need to do is delete the line)

Something to consider here is that if we immediately drop that deprecated field, then it's possible it could cause issues during upgrades from previous versions of EG to this new version -- the EG control plane gets upgraded, and before all the data planes have been upgraded, it sends out an xDS config that does not contain this field, which is invalid for older versions of Envoy. In Contour we tend to upgrade Envoy in one release, and then address deprecations / start making use of new features from that Envoy version in the next Contour release, which usually avoids this issue. Maybe it's too soon to worry about this for EG, but wanted to raise it for consideration. The other thing we need to think about is EG's release cadence relative to Envoy's -- if we're only releasing every 6mo, while Envoy is every quarter, then we may need to do skip some minor versions of Envoy, which could be tricky. IMO we should consider shipping quarterly as well to align with Envoy, but maybe 2-4 weeks after new Envoy minor versions come out so we can pick them up.

thanks for raising those issues, agree with the depreciation strategy
also agree we consider we should consider quarterly releases, something we can discuss in the next community meeting

I agree that EG should coincide with Envoy. If so, we need to review the milestones, roadmap, etc and realign.

@skriss do you mind creating issues or agenda topics to address the release cadence and depreciation strategy?

Something to consider here is that if we immediately drop that deprecated field, then it's possible it could cause issues during upgrades from previous versions of EG to this new version -- the EG control plane gets upgraded, and before all the data planes have been upgraded, it sends out an xDS config that does not contain this field, which is invalid for older versions of Envoy.

total_weights has been optional for quite a while so I believe it is safe to remove in this case.

do you mind creating issues or agenda topics to address the release cadence and depreciation strategy?

xref #663