Skip to content

Add hostname to backend#6503

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
Ri7ay:Add-hostname-to-backend
Jul 16, 2025
Merged

Add hostname to backend#6503
arkodg merged 2 commits intoenvoyproxy:mainfrom
Ri7ay:Add-hostname-to-backend

Conversation

@Ri7ay
Copy link
Copy Markdown
Contributor

@Ri7ay Ri7ay commented Jul 10, 2025

What type of PR is this?

  • "feat: add hostname to endpoint"

What this PR does / why we need it:
Relates to the implementation for Add hostname to BackendEndpoint (Ref: #6280)

Which issue(s) this PR fixes:
xRef: #6280

Release Notes: No

@Ri7ay Ri7ay requested a review from a team as a code owner July 10, 2025 19:49
@arkodg arkodg added this to the v1.5.0-rc.1 Release milestone Jul 10, 2025
arkodg
arkodg reviewed Jul 10, 2025
View reviewed changes
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Jul 10, 2025

the PR looks good @Ri7ay

  • can you sign your commit and force push
  • added one comment

@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch 2 times, most recently from 16a95b2 to 58d81e3 Compare July 10, 2025 20:06
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.76%. Comparing base (f81eb76) to head (da53df0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/backend.go 72.41% 6 Missing and 2 partials ⚠️
internal/gatewayapi/route.go 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6503      +/-   ##
==========================================
+ Coverage   70.75%   70.76%   +0.01%     
==========================================
  Files         220      220              
  Lines       37823    37836      +13     
==========================================
+ Hits        26761    26774      +13     
+ Misses       9502     9500       -2     
- Partials     1560     1562       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch 3 times, most recently from f7558b6 to 6709eb7 Compare July 10, 2025 23:48
shawnh2
shawnh2 reviewed Jul 11, 2025
View reviewed changes
@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from 6709eb7 to 713651a Compare July 11, 2025 07:31
@Ri7ay Ri7ay requested review from arkodg and shawnh2 July 11, 2025 16:01
arkodg
arkodg reviewed Jul 11, 2025
View reviewed changes
@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from d848dae to 9ab8b86 Compare July 11, 2025 22:03
@Ri7ay Ri7ay requested a review from arkodg July 11, 2025 22:04
zirain
zirain reviewed Jul 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, would be better to add a test in gatwayapi layer.

@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from 9ab8b86 to a17236c Compare July 12, 2025 08:47
@Ri7ay Ri7ay requested a review from zirain July 12, 2025 08:53
arkodg
arkodg reviewed Jul 15, 2025
View reviewed changes
internal/xds/translator/cluster_test.go Outdated
Copy link
Copy Markdown
Contributor

@arkodg arkodg Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used

@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from a17236c to 5ba15bd Compare July 15, 2025 08:29
@Ri7ay Ri7ay requested a review from arkodg July 15, 2025 08:34
arkodg
arkodg reviewed Jul 15, 2025
View reviewed changes
internal/ir/xds.go Outdated
Copy link
Copy Markdown
Contributor

@arkodg arkodg Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apologies for just noticing this
the Hostname is per Endpoint in the API, so it should be under Endpoint where it was before

Copy link
Copy Markdown
Contributor Author

@Ri7ay Ri7ay Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, back to the original version.

@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from 5ba15bd to 77b4148 Compare July 15, 2025 23:26
@Ri7ay Ri7ay requested a review from arkodg July 15, 2025 23:27
arkodg
arkodg previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg requested review from a team July 16, 2025 00:49
shawnh2
shawnh2 previously approved these changes Jul 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ri7ay
feat(hostname): Add hostname to backend
b04e2a6 
Signed-off-by: Zakhar Zakharov <zakhar.zakharov.zz16@gmail.com>
@Ri7ay Ri7ay dismissed stale reviews from arkodg and shawnh2 via b04e2a6 July 16, 2025 12:53
@Ri7ay Ri7ay force-pushed the Add-hostname-to-backend branch from 03cf81a to b04e2a6 Compare July 16, 2025 12:53
@Ri7ay
Copy link
Copy Markdown
Contributor Author

Ri7ay commented Jul 16, 2025

Passed make -k gen-chek so that ci passed, can you approve it again please.
@arkodg @shawnh2

@Ri7ay Ri7ay requested review from arkodg and shawnh2 July 16, 2025 12:56
@arkodg arkodg merged commit 66e63aa into envoyproxy:main Jul 16, 2025
29 of 31 checks passed
@codefromthecrypt codefromthecrypt mentioned this pull request Jan 29, 2026
Closed
@guydc guydc mentioned this pull request Jan 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@zirain zirain Awaiting requested review from zirain

@arkodg arkodg Awaiting requested review from arkodg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.0-rc.1 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@Ri7ay @arkodg @zirain @shawnh2 @nacx