test(ci): Install and run docker-mac-net-connect when running e2e on macos#6368
Merged
zirain merged 5 commits intoenvoyproxy:mainfrom Jul 17, 2025
Merged
test(ci): Install and run docker-mac-net-connect when running e2e on macos#6368zirain merged 5 commits intoenvoyproxy:mainfrom
zirain merged 5 commits intoenvoyproxy:mainfrom
Conversation
0e89455 to
110abd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6368 +/- ##
==========================================
+ Coverage 71.05% 71.09% +0.03%
==========================================
Files 220 220
Lines 37892 37892
==========================================
+ Hits 26926 26938 +12
+ Misses 9393 9383 -10
+ Partials 1573 1571 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
110abd4 to
7882ff4
Compare
sudiptob2
commented
Jun 21, 2025
sudiptob2
commented
Jun 21, 2025
sudiptob2
commented
Jun 21, 2025
tools/hack/manage-mac-net-connect.sh
Outdated
Comment on lines
17
to
19
Member
Author
There was a problem hiding this comment.
brew services info docker-mac-net-connect --json provides following output while my testing.
[
{
"name": "docker-mac-net-connect",
"service_name": "homebrew.mxcl.docker-mac-net-connect",
"running": false,
"loaded": false,
"schedulable": false,
"pid": null,
"exit_code": null,
"user": "root",
"status": "none",
"file": "/Users/sudiptobaral/Library/LaunchAgents/homebrew.mxcl.docker-mac-net-connect.plist",
"registered": true,
"loaded_file": null,
"command": "/opt/homebrew/opt/docker-mac-net-connect/bin/docker-mac-net-connect",
"working_dir": null,
"root_dir": null,
"log_path": "/opt/homebrew/var/log/docker-mac-net-connect/std_out.log",
"error_log_path": "/opt/homebrew/var/log/docker-mac-net-connect/std_error.log",
"interval": null,
"cron": null
}
]During testing, I noticed that "running": false was returned even when docker-mac-net-connect was clearly running. The only reliable indicator I found was the user field:
- If the service is stopped, the user field is null.
- If the service is running, the user field is always populated (e.g., "root").
b23bb6f to
d835b00
Compare
56b9583 to
bb08f7e
Compare
bb08f7e to
fa17030
Compare
fa17030 to
1aae2a8
Compare
…MacOS. Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
Signed-off-by: sudipto baral <sudiptobaral.me@gmail.com>
1aae2a8 to
481174c
Compare
zirain
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces scripts to automate the setup and cleanup of docker-mac-net-connect for local macOS development environments.
Features
Automatically stop the service afterward.Users will be responsible for stopping the service if needed.DOCKER_MAC_NET_CONNECT=false.Covered Logic
HOMEBREW_GOPROXY.Fixes #6325