Ensure rbac is created before the certgen job when using ArgoCD#5848
Merged
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom Apr 29, 2025
Merged
Ensure rbac is created before the certgen job when using ArgoCD#5848zhaohuabing merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
arkodg
reviewed
Apr 29, 2025
17026f6 to
48ab5f9
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
arkodg
reviewed
Apr 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5848 +/- ##
==========================================
- Coverage 65.39% 65.30% -0.09%
==========================================
Files 220 221 +1
Lines 35184 35314 +130
==========================================
+ Hits 23008 23062 +54
- Misses 10762 10824 +62
- Partials 1414 1428 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
arkodg
approved these changes
Apr 29, 2025
zirain
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5223