Add metrics for topologyInjector webhook#5835
Conversation
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
|
CC @zirain |
There was a problem hiding this comment.
It would be better if you can add this metric in a new section under https://github.com/envoyproxy/gateway/blob/main/site/content/en/latest/tasks/observability/gateway-exported-metrics.md
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (23.07%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5835 +/- ##
==========================================
+ Coverage 65.31% 65.35% +0.03%
==========================================
Files 221 221
Lines 35314 35321 +7
==========================================
+ Hits 23066 23084 +18
+ Misses 10820 10814 -6
+ Partials 1428 1423 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
c09c948 to
d21b0c7
Compare
…gateway into topology-injector-metrics
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
|
/retest |
|
Not sure how to go about adding tests for the metrics change. Is that required for merging? |
it would be better to have, but not a blocker. it shouldn't be very hard to add in the existing zone e2e. |
What type of PR is this?
What this PR does / why we need it:
Folllow-up to #5352
Which issue(s) this PR fixes:
Fixes #
Release Notes: No