API: TLS API for dynamic resolver Backend#5794
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
| } | ||
|
|
||
| // BackendTLSSettings holds the TLS settings for the backend. | ||
| // Only used for DynamicResolver backends. |
There was a problem hiding this comment.
// +kubebuilder:validation:XValidation:message="must not contain both CACertificateRefs and WellKnownCACertificates",rule="!(has(self.caCertificateRefs) && size(self.caCertificateRefs) > 0 && has(self.wellKnownCACertificates) && self.wellKnownCACertificates != "")"
// +kubebuilder:validation:XValidation:message="must specify either CACertificateRefs or WellKnownCACertificates",rule="(has(self.caCertificateRefs) && size(self.caCertificateRefs) > 0 || has(self.wellKnownCACertificates) && self.wellKnownCACertificates != "")"
|
minor comment around CEL, else LGTM, thanks for adding this ! |
I plan to add CEL and CEL tests in the implementation PR to focus this one on the API itself :-) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5794 +/- ##
==========================================
+ Coverage 65.19% 65.32% +0.12%
==========================================
Files 214 216 +2
Lines 34321 34691 +370
==========================================
+ Hits 22377 22662 +285
- Misses 10591 10641 +50
- Partials 1353 1388 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR introduces the TLS configuration API for the
DynamicResolverBackend type.We are not using the gateway API
BackendTLSPolicyto configure TLS forDynamicResolver, because it requires a fixed hostname, which isn't compatible with the dynamic nature of these backends.Release note: the release note will be added in the implementation PR.
CEL validation for API will be added in the implementation PR.