Skip to content

Revert "bugfix: ignore some unnecessary requests to apiserver. (#4362)"#5737

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:ep-hpa
Apr 17, 2025
Merged

Revert "bugfix: ignore some unnecessary requests to apiserver. (#4362)"#5737
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:ep-hpa

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Apr 15, 2025

fixes: #5357

Revert fe1e8bd, add e2e to make sure it worked as expected.

@zirain zirain requested a review from a team as a code owner April 15, 2025 05:02
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.48%. Comparing base (096cb8d) to head (87bdd22).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...frastructure/kubernetes/proxy/resource_provider.go 68.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5737      +/-   ##
==========================================
+ Coverage   65.19%   65.48%   +0.28%     
==========================================
  Files         214      214              
  Lines       34321    34388      +67     
==========================================
+ Hits        22377    22520     +143     
+ Misses      10591    10506      -85     
- Partials     1353     1362       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain zirain force-pushed the ep-hpa branch 2 times, most recently from 57c99bb to 4b4cc52 Compare April 16, 2025 01:00
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

…proxy#4362)"

This reverts commit fe1e8bd.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain merged commit 98b939a into envoyproxy:main Apr 17, 2025
9 checks passed
@zirain zirain deleted the ep-hpa branch April 17, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HPA not removed after enable and disable.

3 participants