infra: delete resource if exists when using customized name#5569
Merged
arkodg merged 6 commits intoenvoyproxy:mainfrom Mar 28, 2025
Merged
infra: delete resource if exists when using customized name#5569arkodg merged 6 commits intoenvoyproxy:mainfrom
arkodg merged 6 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5569 +/- ##
==========================================
- Coverage 65.26% 65.25% -0.02%
==========================================
Files 213 213
Lines 34073 34129 +56
==========================================
+ Hits 22237 22270 +33
- Misses 10501 10521 +20
- Partials 1335 1338 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Mar 21, 2025
Member
Author
|
@arkodg should we highlight that EG does not guarantee with zero downtime when using customized name? |
shawnh2
reviewed
Mar 22, 2025
shawnh2
previously approved these changes
Mar 22, 2025
arkodg
reviewed
Mar 27, 2025
Contributor
There was a problem hiding this comment.
won't be have infrastructure twice
gateway/api/v1alpha1/envoygateway_types.go
Line 148 in 55fc01f
kubernetes instead ?
arkodg
reviewed
Mar 27, 2025
2029a05 to
40208e6
Compare
arkodg
approved these changes
Mar 28, 2025
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
cnvergence
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #4380