Fixes race condition on provider/runner#5538
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Mar 18, 2025
Merged
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
mathetake
commented
Mar 18, 2025
| r.Logger.Info("Running provider", "type", p.Type()) | ||
| go func() { | ||
| if err = p.Start(ctx); err != nil { | ||
| if err := p.Start(ctx); err != nil { |
Member
Author
There was a problem hiding this comment.
err is a return value from the outer Start so this is a race without shadowing
This was referenced Mar 18, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5538 +/- ##
==========================================
- Coverage 65.23% 65.19% -0.04%
==========================================
Files 213 213
Lines 34042 34042
==========================================
- Hits 22206 22193 -13
- Misses 10510 10520 +10
- Partials 1326 1329 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cnvergence
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: race condition
What this PR does / why we need it:
There's a race condition in provider/runner.Start where it writes values into
errvariable from multiple goroutines.Which issue(s) this PR fixes:
Fixes #5505
Release Notes: No