Fixes race condition of watchable.Map between Close and Subscribe#5522
Merged
Xunzhuo merged 2 commits intoenvoyproxy:mainfrom Mar 18, 2025
Merged
Fixes race condition of watchable.Map between Close and Subscribe#5522Xunzhuo merged 2 commits intoenvoyproxy:mainfrom
Xunzhuo merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Member
Author
|
cc @arkodg |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (44.44%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
==========================================
+ Coverage 65.17% 65.25% +0.07%
==========================================
Files 213 213
Lines 34029 34034 +5
==========================================
+ Hits 22179 22209 +30
+ Misses 10520 10501 -19
+ Partials 1330 1324 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: race condition on using watchable.Map
What this PR does / why we need it:
These watchable.Map's two methods, Subscribe and Close, are not supposed to be called from multiple goroutines since inside these implementations, Subscribe calls WaitGroup.Add vs Close calls WaitGroup.Wait, which is a forbidden use of WaitGroup API. This partially fixes the forbidden use regarding standalone mode, but there's a plenty of places that violates the rule, which will be fixed in a follow up PR.
Which issue(s) this PR fixes:
Partially fixes: #5505
Release Notes: No