Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.11%. Comparing base (5b6a35f) to head (630f18e).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #5331      +/-   ##
==========================================
+ Coverage   65.05%   65.11%   +0.05%     
==========================================
  Files         213      213              
  Lines       33588    33586       -2     
==========================================
+ Hits        21851    21869      +18     
+ Misses      10405    10394      -11     
+ Partials     1332     1323       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hey can you run 'make testdata' and 'make generate' and commit those changes ?

please send API PR first, otherwise there would be too much rework on conflict and naming.

@zirain #5342 Please let me.

@zirain please review

@surenraju can you make ci happy?

@zirain tests are passing except conformance-test (v1.30.6) Wondering if this is related to my change.

it just a flaky

/retest

This PR looks great!

@surenraju could you please also modify the e2e test to add the username header and verify it in the forwarded request?

• Add forwardUsernameHeader: "x-username" to the SecurityPolicy used for the test:

  gateway/test/e2e/testdata/basic-auth.yaml

  Lines 69 to 95 in 52a7970

  	apiVersion: gateway.envoyproxy.io/v1alpha1
  	kind: SecurityPolicy
  	metadata:
  	name: basic-auth-1
  	namespace: gateway-conformance-infra
  	spec:
  	targetRefs:
  	- group: gateway.networking.k8s.io
  	kind: HTTPRoute
  	name: http-with-basic-auth-1
  	basicAuth:
  	users:
  	name: "basic-auth-users-secret-1"
  	---
  	apiVersion: gateway.envoyproxy.io/v1alpha1
  	kind: SecurityPolicy
  	metadata:
  	name: basic-auth-2
  	namespace: gateway-conformance-infra
  	spec:
  	targetRefs:
  	- group: gateway.networking.k8s.io
  	kind: HTTPRoute
  	name: http-with-basic-auth-2
  	basicAuth:
  	users:
  	name: "basic-auth-users-secret-2"

• Verify that the forwarded request contains the forwardUsernameHeader header in the test:
  

  gateway/test/e2e/tests/basic_auth.go

  Lines 48 to 58 in 52a7970

  	expectedResponse := http.ExpectedResponse{
  	Request: http.Request{
  	Path: "/basic-auth-1",
  	Headers: map[string]string{
  	"Authorization": "Basic dXNlcjE6dGVzdDE=", // user1:test1
  	},
  	},
  	Response: http.Response{
  	StatusCode: 200,
  	},
  	Namespace: ns,

  
  You'll need to add an ExpectedRequest in the ExpectedResponse, something similar to:

                               ExpectedRequest: &http.ExpectedRequest{
					Request: http.Request{
						Path: "/basic-auth-1",
						Headers: map[string]string{
							"Authorization": "Basic dXNlcjE6dGVzdDE=", // user1:test1
							"forwardUsernameHeader": "x-username",
						},
					},
				},

@surenraju Could you please add a line to the release note?

/retest

/retest

@zirain @zhaohuabing all checks passed. Please review.