Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (d1730a8) to head (08643b3).
Report is 61 commits behind head on main.

@@            Coverage Diff             @@
##             main    #5312      +/-   ##
==========================================
- Coverage   64.97%   64.93%   -0.05%     
==========================================
  Files         214      214              
  Lines       33532    33532              
==========================================
- Hits        21789    21774      -15     
- Misses      10400    10413      +13     
- Partials     1343     1345       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

will the secret updates be picked up?

like changing the content

like changing the content

yah, we have existing logic for it, which is used in other places (TLS Certs, Basic Auth etc)

great! we might be able to utilize this in the future iteration and simplify the AI Gateway controller code cc @yuzisun @aabchoo @nacx

but at the moment the core logic is tied with AWS signing so this can only be used for API key auth 😞

but at the moment the core logic is tied with AWS signing so this can only be used for API key auth

I'm not familiar with the API Gateway AWS signing authentication. Could it be a new credential type for the CredentialInjector, similar to the oauth2 credential(which would require some non-trivial work on the Envoy side)? If so, then it could also be entirely handled within EG.

but at the moment the core logic is tied with AWS signing so this can only be used for API key auth 😞

I am not sure what this AWS signing has to do with credential injector, but in its current state credential injector will already be useful for us.