Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5304 +/- ##
==========================================
- Coverage 64.94% 64.90% -0.05%
==========================================
Files 213 213
Lines 33454 33454
==========================================
- Hits 21726 21712 -14
- Misses 10400 10409 +9
- Partials 1328 1333 +5 ☔ View full report in Codecov by Sentry. |
zirain
commented
Feb 18, 2025
tools/make/tools.mk
Outdated
Member
Author
There was a problem hiding this comment.
cannot find a way to remove this
b1193cd to
792e31b
Compare
arkodg
approved these changes
Feb 20, 2025
Contributor
arkodg
left a comment
There was a problem hiding this comment.
LGTM thanks !
once merged, lets drop a note in #gateway-dev to ask users to upgrade to v1.24
Member
Author
|
go tool is available in 1.23. |
Signed-off-by: zirain <zirain2009@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info in https://tip.golang.org/doc/modules/managing-dependencies#tools