fix: create a cluster per destination setting for backends with filters#5269
Merged
arkodg merged 12 commits intoenvoyproxy:mainfrom Feb 26, 2025
Merged
fix: create a cluster per destination setting for backends with filters#5269arkodg merged 12 commits intoenvoyproxy:mainfrom
arkodg merged 12 commits intoenvoyproxy:mainfrom
Conversation
Contributor
|
CP to 1.3.1? |
ae66f70 to
b510499
Compare
zirain
reviewed
Feb 24, 2025
internal/cmd/egctl/testdata/translate/out/jwt-single-route-single-match-to-xds.all.json
Outdated
Show resolved
Hide resolved
zirain
reviewed
Feb 24, 2025
added 10 commits
February 24, 2025 17:22
* create a unique name by adding a new destination setting field * create a unique cluster per dest setting if the setting contains filters * reuse that for locality region name as well Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
dbe351c to
981faa8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5269 +/- ##
==========================================
+ Coverage 64.97% 65.06% +0.09%
==========================================
Files 213 213
Lines 33505 33570 +65
==========================================
+ Hits 21769 21843 +74
+ Misses 10405 10398 -7
+ Partials 1331 1329 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
jukie
approved these changes
Feb 25, 2025
zirain
previously approved these changes
Feb 26, 2025
Member
zirain
left a comment
There was a problem hiding this comment.
LGTM, can you fix the conflict?
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
zirain
reviewed
Feb 26, 2025
| @@ -18,6 +18,8 @@ new features: | | |||
| Added support for HorizontalPodAutoscaler to helm chart | |||
|
|
|||
| bug fixes: | | |||
|
|
|||
zirain
approved these changes
Feb 26, 2025
zhaohuabing
reviewed
Feb 26, 2025
|
|
||
| // TODO: rename this, so that we can share backend with tracing? | ||
| destName := fmt.Sprintf("accesslog_als_%d_%d", i, j) | ||
| settingName := irDestinationSettingName(destName, -1) |
Member
There was a problem hiding this comment.
nit: non-blocking
Defining a const with a meaningful name would help understand the logic :-)
Contributor
Author
There was a problem hiding this comment.
Agree, I left it as is, can improve in follow up
zhaohuabing
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5230