Skip to content

fix: implement num-route-per-host for benchmark scale_httproutes case#5235

Merged
zirain merged 4 commits intoenvoyproxy:mainfrom
shawnh2:benchmark-hostname
Feb 11, 2025
Merged

fix: implement num-route-per-host for benchmark scale_httproutes case#5235
zirain merged 4 commits intoenvoyproxy:mainfrom
shawnh2:benchmark-hostname

Conversation

@shawnh2
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 commented Feb 9, 2025

What type of PR is this?

What this PR does / why we need it:

follow-up implement of #3599 (comment)

Which issue(s) this PR fixes:

fix #3693

Release Notes: No

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 mentioned this pull request Feb 9, 2025
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.92%. Comparing base (a58021e) to head (1b91d72).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
+ Coverage   66.89%   66.92%   +0.03%     
==========================================
  Files         210      210              
  Lines       33027    33027              
==========================================
+ Hits        22093    22103      +10     
+ Misses       9593     9584       -9     
+ Partials     1341     1340       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2 shawnh2 force-pushed the benchmark-hostname branch from 63fe799 to 68a215d Compare February 9, 2025 09:56
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 marked this pull request as ready for review February 9, 2025 10:50
@shawnh2 shawnh2 requested a review from a team as a code owner February 9, 2025 10:50
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team February 10, 2025 22:12
@zirain zirain merged commit b2519fc into envoyproxy:main Feb 11, 2025
25 checks passed
@shawnh2 shawnh2 deleted the benchmark-hostname branch February 11, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmark Test Enhancement

3 participants