Skip to content

chore: always validate the proto messages#4984

Merged
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-proto-validation
Jan 7, 2025
Merged

chore: always validate the proto messages#4984
zhaohuabing merged 1 commit intoenvoyproxy:mainfrom
zhaohuabing:fix-proto-validation

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

Fixes: #4554
Follow up: #4499

@zhaohuabing zhaohuabing requested a review from a team as a code owner December 31, 2024 04:32
@zhaohuabing zhaohuabing changed the title always validate the proto messages chore: always validate the proto messages Dec 31, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 55.05618% with 40 lines in your changes missing coverage. Please review.

Project coverage is 66.78%. Comparing base (2a5ecaf) to head (db9c78c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/accesslog.go 50.00% 17 Missing and 10 partials ⚠️
internal/xds/filters/wellknown.go 72.00% 4 Missing and 3 partials ⚠️
internal/xds/translator/httpfilters.go 40.00% 2 Missing and 1 partial ⚠️
internal/xds/translator/route.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4984      +/-   ##
==========================================
+ Coverage   66.77%   66.78%   +0.01%     
==========================================
  Files         209      209              
  Lines       32100    32180      +80     
==========================================
+ Hits        21434    21493      +59     
- Misses       9379     9392      +13     
- Partials     1287     1295       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain zirain force-pushed the fix-proto-validation branch from cdf782a to 74b5c63 Compare January 6, 2025 02:52
@arkodg arkodg requested review from a team January 6, 2025 19:18
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
@zirain zirain force-pushed the fix-proto-validation branch from 74b5c63 to db9c78c Compare January 7, 2025 02:12
@zhaohuabing zhaohuabing merged commit 51c11b9 into envoyproxy:main Jan 7, 2025
@zhaohuabing zhaohuabing deleted the fix-proto-validation branch January 7, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: clean up anypb.ToAny without validation

3 participants