Skip to content

xds: fix ipFamily always nil#4782

Merged
zirain merged 13 commits intoenvoyproxy:mainfrom
juwon8891:always-nil
Dec 5, 2024
Merged

xds: fix ipFamily always nil#4782
zirain merged 13 commits intoenvoyproxy:mainfrom
juwon8891:always-nil

Conversation

@juwon8891
Copy link
Copy Markdown
Contributor

chore: fix ipFamily always nil

What this PR does / why we need it:
This PR improves IP family configuration handling across different listener types and updates the DNS lookup strategy for better dual-stack support.

  • Add consistent IP family handling across all listener types

Which issue(s) this PR fixes:
Fixes #4761

@juwon8891 juwon8891 requested a review from a team as a code owner November 26, 2024 06:31
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.68%. Comparing base (bcb4b4d) to head (a20af72).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/helpers.go 86.36% 3 Missing ⚠️
internal/xds/translator/listener.go 33.33% 0 Missing and 2 partials ⚠️
internal/gatewayapi/listener.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4782      +/-   ##
==========================================
+ Coverage   65.60%   65.68%   +0.07%     
==========================================
  Files         211      211              
  Lines       32015    32064      +49     
==========================================
+ Hits        21004    21061      +57     
+ Misses       9766     9760       -6     
+ Partials     1245     1243       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain changed the title chore: fix ipFamily always nil xds: fix ipFamily always nil Nov 27, 2024
@juwon8891 juwon8891 force-pushed the always-nil branch 2 times, most recently from f620e41 to 64f4832 Compare November 27, 2024 07:58
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
juwon8891 and others added 2 commits December 3, 2024 10:40
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Copy link
Copy Markdown
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise LGTM.

juwon8891 and others added 2 commits December 4, 2024 17:29
Signed-off-by: Juwon Hwang (Kevin) <juwon8891@gmail.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain zirain merged commit 226082b into envoyproxy:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xdsClusterArgs.ipFamily always nil

3 participants