Skip to content

xds: use Cluster_AUTO DnsLookupFamily#4740

Merged
zirain merged 3 commits intoenvoyproxy:mainfrom
zirain:dns-cluster-auto
Nov 20, 2024
Merged

xds: use Cluster_AUTO DnsLookupFamily#4740
zirain merged 3 commits intoenvoyproxy:mainfrom
zirain:dns-cluster-auto

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Nov 19, 2024

fixes: #4605

@zirain zirain requested a review from a team as a code owner November 19, 2024 09:17
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Nov 19, 2024

test passed on #4690

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.66%. Comparing base (86d750a) to head (5251bed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 11.11% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
+ Coverage   65.63%   65.66%   +0.03%     
==========================================
  Files         211      211              
  Lines       31996    32001       +5     
==========================================
+ Hits        21000    21013      +13     
+ Misses       9757     9752       -5     
+ Partials     1239     1236       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

arkodg
arkodg reviewed Nov 19, 2024
View reviewed changes
@zirain zirain requested a review from arkodg November 20, 2024 02:17
arkodg
arkodg reviewed Nov 20, 2024
View reviewed changes
@zirain
xds: use Cluster_AUTO DnsLookupFamily
89d2db1 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
nit
cfa9867 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
gen
5251bed 
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg approved these changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team November 20, 2024 03:07
@zirain zirain merged commit a924cec into envoyproxy:main Nov 20, 2024
@zirain zirain deleted the dns-cluster-auto branch November 20, 2024 03:51
@zetaab zetaab mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@arkodg arkodg arkodg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cluster_V4_ONLY cause no healthy upstream on IPv6 first cluster

3 participants

@zirain @zhaohuabing @arkodg