Skip to content

chore: dnsSearch on kind cluster#4691

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:kind/dnsSearch
Nov 11, 2024
Merged

chore: dnsSearch on kind cluster#4691
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:kind/dnsSearch

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Nov 10, 2024

xref: #4572

@zirain
chore: dnsSearch on kind cluster
7f03d07 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner November 10, 2024 15:34
@zirain zirain mentioned this pull request Nov 10, 2024
Closed
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (2c98617) to head (7f03d07).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4691      +/-   ##
==========================================
+ Coverage   65.53%   65.55%   +0.01%     
==========================================
  Files         211      211              
  Lines       31954    31954              
==========================================
+ Hits        20941    20946       +5     
+ Misses       9770     9767       -3     
+ Partials     1243     1241       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Nov 10, 2024

nslookup worked as excepted:

k exec -it deployments/dnsutils -- nslookup sleep.default.svc.cluster.local
Server:		fd00:10:96::a
Address:	fd00:10:96::a#53

Name:	sleep.default.svc.cluster.local
Address: fd00:10:96::1d41

k exec -it deployments/dnsutils -- cat /etc/resolv.conf
search default.svc.cluster.local svc.cluster.local cluster.local
nameserver fd00:10:96::a
options ndots:5

arkodg
arkodg approved these changes Nov 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team November 10, 2024 17:24
@zirain zirain merged commit ec56a83 into envoyproxy:main Nov 11, 2024
@zirain zirain deleted the kind/dnsSearch branch November 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

+1 more reviewer

@qicz qicz qicz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zirain @qicz @arkodg