Skip to content

[release/v1.1] bump envoy#4596

Merged
arkodg merged 1 commit intoenvoyproxy:release/v1.1from
guydc:release-v1-1-3-bumps
Nov 1, 2024
Merged

[release/v1.1] bump envoy#4596
arkodg merged 1 commit intoenvoyproxy:release/v1.1from
guydc:release-v1-1-3-bumps

Conversation

@guydc
Copy link
Copy Markdown
Contributor

@guydc guydc commented Oct 31, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@guydc guydc requested a review from a team as a code owner October 31, 2024 21:26
arkodg
arkodg previously approved these changes Oct 31, 2024
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 31, 2024

@guydc
looks like another change is needed

+++ b/examples/extension-server/go.mod
@@ -10,7 +10,7 @@ require (
 	google.golang.org/protobuf v1.34.2
 	k8s.io/apimachinery v0.30.2
 	sigs.k8s.io/controller-runtime v0.18.4
-	sigs.k8s.io/gateway-api v1.1.0
+	sigs.k8s.io/gateway-api v1.1.1
 )

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (13fee13) to head (963e38f).
Report is 1 commits behind head on release/v1.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.1    #4596      +/-   ##
================================================
- Coverage         66.63%   66.61%   -0.02%     
================================================
  Files               183      183              
  Lines             28112    28112              
================================================
- Hits              18732    18727       -5     
- Misses             8294     8298       +4     
- Partials           1086     1087       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Oct 31, 2024
@arkodg arkodg changed the title bump envoy and gw-api [release/v1.1] bump envoy and gw-api Oct 31, 2024
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Nov 1, 2024

all the GRPCRoute tests are failing, does the build work with https://gateway.envoyproxy.io/docs/tasks/traffic/grpc-routing/ , if it doesnt we should report this upstream and imo release without the patch release

zhaohuabing
zhaohuabing previously approved these changes Nov 1, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc dismissed stale reviews from zhaohuabing and arkodg via 963e38f November 1, 2024 12:04
@guydc guydc force-pushed the release-v1-1-3-bumps branch from 40ca926 to 963e38f Compare November 1, 2024 12:04
@guydc guydc changed the title [release/v1.1] bump envoy and gw-api [release/v1.1] bump envoy Nov 1, 2024
@arkodg arkodg merged commit 180c6ce into envoyproxy:release/v1.1 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants