Skip to content

feat: add host-infra provider support#4481

Merged
zirain merged 5 commits intoenvoyproxy:mainfrom
shawnh2:host-infra
Oct 22, 2024
Merged

feat: add host-infra provider support#4481
zirain merged 5 commits intoenvoyproxy:mainfrom
shawnh2:host-infra

Conversation

@shawnh2
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 commented Oct 19, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref #1393

@shawnh2
add host-infra provider support
c353d4f 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner October 19, 2024 05:15
@shawnh2
resolve conflicts
46f92b3 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.79133% with 248 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (544bd9c) to head (36a9f17).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/certgen.go 17.54% 37 Missing and 10 partials ⚠️
internal/infrastructure/host/proxy_infra.go 14.28% 42 Missing ⚠️
internal/infrastructure/host/infra.go 20.00% 33 Missing and 3 partials ⚠️
internal/crypto/cert_load.go 0.00% 31 Missing ⚠️
internal/infrastructure/manager.go 0.00% 19 Missing ⚠️
internal/globalratelimit/runner/runner.go 0.00% 18 Missing ⚠️
internal/xds/server/runner/runner.go 0.00% 18 Missing ⚠️
internal/gatewayapi/runner/runner.go 36.00% 16 Missing ⚠️
internal/infrastructure/common/proxy_args.go 84.21% 4 Missing and 2 partials ⚠️
api/v1alpha1/envoygateway_helpers.go 33.33% 4 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
- Coverage   65.95%   65.77%   -0.18%     
==========================================
  Files         203      209       +6     
  Lines       31154    31352     +198     
==========================================
+ Hits        20547    20622      +75     
- Misses       9420     9533     +113     
- Partials     1187     1197      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
add more tests and polish code for each runner
b64d091 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
arkodg
arkodg previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! thanks for refactoring a bunch of the common code
standalone mode is finally here 🚀

@arkodg arkodg requested review from a team October 22, 2024 01:32
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 22, 2024

hey @shawnh2 when we write docs, we should probably highlight that standalone mode is still experimental and not meant for production yet, and not all features work out of the box (like global ratelimit)

@arkodg arkodg added this to the v1.2.0-rc1 milestone Oct 22, 2024
Xunzhuo
Xunzhuo previously approved these changes Oct 22, 2024
View reviewed changes
@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Oct 22, 2024 •
edited
Loading

@shawnh2 do we have built any e2e tests for host mode? and we need a user-facing docs for a quickstart and a little bit words about its scenarios

@shawnh2
Copy link
Copy Markdown
Contributor Author

shawnh2 commented Oct 22, 2024

@shawnh2 do we have built any e2e tests for host mode? and we need a user-facing docs for a quickstart and a little bit words about its scenarios

will add user-facing doc & e2e test as a follow-up.

@shawnh2 shawnh2 mentioned this pull request Oct 22, 2024
Closed
5 tasks
@zirain
Copy link
Copy Markdown
Member

zirain commented Oct 22, 2024

@shawnh2 please rebase to make CI happy.

@shawnh2
resolve conflicts
76d8c33 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 dismissed stale reviews from Xunzhuo and arkodg via 76d8c33 October 22, 2024 13:07
@shawnh2
fix lint
36a9f17 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain
zirain approved these changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's an experimental feature, let's land it in v1.2 for more feedback.

@zirain zirain merged commit 3371421 into envoyproxy:main Oct 22, 2024
@shawnh2 shawnh2 deleted the host-infra branch October 23, 2024 00:34
@guydc guydc mentioned this pull request Dec 17, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zirain zirain zirain approved these changes

@arkodg arkodg arkodg approved these changes

@Xunzhuo Xunzhuo Xunzhuo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.2.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@shawnh2 @arkodg @Xunzhuo @zirain