[release/v1.1] fix: don't lose timeout settings that originate from the route when t…#4450
Merged
zirain merged 1 commit intoenvoyproxy:release/v1.1from Oct 16, 2024
Merged
Conversation
…ranslating the backend traffic policy (envoyproxy#4095) (#85) * Don't lose timeout settings that originate from the route when translating the backend traffic policy * Improve the readability of the timeout processing code. * Removed some logically unreachable code. --------- (cherry picked from commit 262e046) Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Co-authored-by: Lior Okman <lior.okman@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.1 #4450 +/- ##
================================================
+ Coverage 67.34% 67.37% +0.03%
================================================
Files 183 183
Lines 22521 22519 -2
================================================
+ Hits 15166 15173 +7
+ Misses 6265 6259 -6
+ Partials 1090 1087 -3 ☔ View full report in Codecov by Sentry. |
arkodg
approved these changes
Oct 16, 2024
zirain
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3251
…ranslating the backend traffic policy (#4095) (#85)
Don't lose timeout settings that originate from the route when translating the backend traffic policy
Improve the readability of the timeout processing code.
Removed some logically unreachable code.
(cherry picked from commit 262e046)
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #