performance: changing Infra and Xds IR log values to JSONString#4263
performance: changing Infra and Xds IR log values to JSONString#4263Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4263 +/- ##
==========================================
+ Coverage 65.61% 65.65% +0.03%
==========================================
Files 197 197
Lines 23551 23557 +6
==========================================
+ Hits 15454 15466 +12
+ Misses 6983 6981 -2
+ Partials 1114 1110 -4 ☔ View full report in Codecov by Sentry. |
|
hey @shawnh2 thanks for improving the perf ! |
| return string(y) | ||
| } | ||
|
|
||
| func (x Xds) JSONString() string { |
There was a problem hiding this comment.
Struct Xds has methods on both value and pointer receivers. The Go Documentation does not recommend such usage.
There was a problem hiding this comment.
Indeed, Xds has methods on both value and pointer receivers, this may be revisited later, not a primary concern in this PR.
| return string(y) | ||
| } | ||
|
|
||
| func (i Infra) JSONString() string { |
There was a problem hiding this comment.
Struct Infra has methods on both value and pointer receivers. Such usage is not recommended by the Go Documentation.
updated |
What type of PR is this?
What this PR does / why we need it:
changing infra and xds IR log value from yaml to json
before:
after:
Which issue(s) this PR fixes:
fix #3698
before:
after:
AYCS, the highest mem cost has been decreased from 1370MB to 590MB.