Skip to content

remove MPL packages#4161

Merged
zirain merged 11 commits intoenvoyproxy:mainfrom
zirain:remove-tempo
Sep 7, 2024
Merged

remove MPL packages#4161
zirain merged 11 commits intoenvoyproxy:mainfrom
zirain:remove-tempo

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Sep 5, 2024 •
edited
Loading

follow up: #4157

cc @shahar-h

@zirain
remove grafana tempo pkg
bc46e1c 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner September 5, 2024 13:48
@zirain
fix hashicorp/go-getter
23ae48c 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain changed the title remove grafana tempo pkg remove MPL packages Sep 5, 2024
@zirain
fix ut
1d0615b 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
update github action
418469a 
Signed-off-by: zirain <zirain2009@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.92%. Comparing base (3584271) to head (cd13bcd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/utils/path/path.go 0.00% 7 Missing ⚠️
internal/cmd/egctl/collect.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4161      +/-   ##
==========================================
- Coverage   67.98%   67.92%   -0.06%     
==========================================
  Files         189      190       +1     
  Lines       23106    23113       +7     
==========================================
- Hits        15708    15700       -8     
- Misses       6278     6290      +12     
- Partials     1120     1123       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shahar-h
shahar-h reviewed Sep 5, 2024
View reviewed changes
@zirain
more fix
2c879cd 
Signed-off-by: zirain <zirain2009@gmail.com>
shahar-h
shahar-h reviewed Sep 5, 2024
View reviewed changes
@zirain
nit
dc6e303 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
remove more
03a1d19 
Signed-off-by: zirain <zirain2009@gmail.com>
shahar-h
shahar-h approved these changes Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahar-h shahar-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

guydc
guydc previously approved these changes Sep 5, 2024
View reviewed changes
@zirain
fix unmarshal
8ec5b3f 
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg reviewed Sep 5, 2024
View reviewed changes
arkodg
arkodg reviewed Sep 5, 2024
View reviewed changes
@zirain
remove tempopb
9b43895 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
address comment
07267d6 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested review from arkodg and guydc September 6, 2024 11:45
arkodg
arkodg previously approved these changes Sep 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@zirain zirain requested a review from arkodg September 7, 2024 02:10
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Sep 7, 2024 

+------------------------------+------+-----------+---------+---------+--------+
| OSV URL                      | CVSS | ECOSYSTEM | PACKAGE | VERSION | SOURCE |
+------------------------------+------+-----------+---------+---------+--------+
| https://osv.dev/GO-2024-3105 |      | Go        | stdlib  | 1.22.5  | go.mod |
| https://osv.dev/GO-2024-[31](https://github.com/envoyproxy/gateway/actions/runs/10747767939/job/29810620873?pr=4161#step:4:32)06 |      | Go        | stdlib  | 1.22.5  | go.mod |
| https://osv.dev/GO-2024-3107 |      | Go        | stdlib  | 1.22.5  | go.mod |
+------------------------------+------+-----------+---------+---------+--------+

will fix it in separated one.

@zirain zirain merged commit a5fc162 into envoyproxy:main Sep 7, 2024
@zirain zirain deleted the remove-tempo branch September 7, 2024 03:33
@shahar-h shahar-h mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkodg arkodg arkodg approved these changes

@guydc guydc Awaiting requested review from guydc

+1 more reviewer

@shahar-h shahar-h shahar-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zirain @arkodg @shahar-h @guydc