Adds HTTPRoute ParentRef Validation#401
Merged
danehans merged 1 commit intoenvoyproxy:mainfrom Sep 23, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 61.20% 61.40% +0.20%
==========================================
Files 36 36
Lines 3714 3762 +48
==========================================
+ Hits 2273 2310 +37
- Misses 1317 1325 +8
- Partials 124 127 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2db4dcb to
1d3b78f
Compare
2b0d11a to
384b8cf
Compare
skriss
reviewed
Sep 22, 2022
skriss
reviewed
Sep 22, 2022
Signed-off-by: danehans <daneyonhansen@gmail.com>
384b8cf to
1250d54
Compare
skriss
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for validating
parentRefsof an HTTPRoute. Previously, the httproute controller would process an HTTPRoute even if it references a gateway that doesn't. This causes EG to perform unnecessary processing. An HTTPRoute does not containstatusso an error is surfaced.Partially Fixes: #301
Signed-off-by: danehans daneyonhansen@gmail.com