chore: move als test resources out of the base#3865
Closed
zhaohuabing wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
chore: move als test resources out of the base#3865zhaohuabing wants to merge 2 commits intoenvoyproxy:mainfrom
zhaohuabing wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3865 +/- ##
=======================================
Coverage 69.26% 69.26%
=======================================
Files 176 176
Lines 21740 21740
=======================================
Hits 15058 15058
Misses 5592 5592
Partials 1090 1090 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@zirain Need your help on this one :-) Any idea why the tests are failing? |
Member
let me take a look |
Member
Author
|
Close this in favor of #3884 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move als test resources out of the base to reduce resource consumption of e2e tests.