Closed
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3810 +/- ##
=======================================
Coverage 69.02% 69.03%
=======================================
Files 176 176
Lines 21760 21760
=======================================
+ Hits 15019 15021 +2
+ Misses 5661 5660 -1
+ Partials 1080 1079 -1 ☔ View full report in Codecov by Sentry. |
zhaohuabing
approved these changes
Jul 11, 2024
Member
zhaohuabing
left a comment
There was a problem hiding this comment.
It would be nice if we could add a few words to explain why this has been changed.
Member
|
did you run |
Member
|
should wait #3815 |
Member
|
Plz run make generate locally, then submit a new commit @guydc :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#3336 was a breaking change