Skip to content

chore: enable lint for benchmark#3754

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:lint-bench
Jul 5, 2024
Merged

chore: enable lint for benchmark#3754
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:lint-bench

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jul 4, 2024

@shawnh2 please help to review the result.

@zirain zirain requested a review from a team as a code owner July 4, 2024 10:49
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (d6b5415) to head (0dad4b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3754      +/-   ##
==========================================
- Coverage   69.03%   69.01%   -0.03%     
==========================================
  Files         176      176              
  Lines       21744    21744              
==========================================
- Hits        15012    15007       -5     
- Misses       5654     5659       +5     
  Partials     1078     1078              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Copy link
Copy Markdown
Member Author

zirain commented Jul 4, 2024

/retest

Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one nit

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from shawnh2 July 5, 2024 01:12
@zirain zirain merged commit df5c265 into envoyproxy:main Jul 5, 2024
@zirain zirain deleted the lint-bench branch July 5, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants